Skip to content

Add Projects api and rework the tests#384

Open
klarkc wants to merge 34 commits intogithub-tools:masterfrom
klarkc:projects-api
Open

Add Projects api and rework the tests#384
klarkc wants to merge 34 commits intogithub-tools:masterfrom
klarkc:projects-api

Conversation

@klarkc
Copy link
Copy Markdown

@klarkc klarkc commented Sep 22, 2016

Adds the new Projects API

The tests are passing, but the lint contains errors from master.

The lib folder are not used in the NPM package, so I put it in the .npmignore

Copy link
Copy Markdown
Member

@clayreimann clayreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there are still 2 lint errors that it would be great if you fixed or forcibly ignored. (I know you didn't introduce one of them)

@klarkc
Copy link
Copy Markdown
Author

klarkc commented Sep 23, 2016

I discovered that the number of testing repos was causing a lot of trouble in tests with timeouts, so I wrote the clearRepo function that basically clear all test repos from the test user. But because of this change, some other tests that do not create testing repos, now are broken. I am working on these tests to first create the testing repo and after that do the tests.

@klarkc klarkc changed the title Add Projects api and remove lib from NPM package Add Projects api and rework the tests Sep 23, 2016
@klarkc
Copy link
Copy Markdown
Author

klarkc commented Sep 27, 2016

I had to do the same thing with teams, so I wrote also the clearTeams function.

@klarkc
Copy link
Copy Markdown
Author

klarkc commented Sep 27, 2016

@clayreimann The travis is testing with concurrency 1? As the tests are made in only one user and organization, the running of parallel tests can cause some unknown errors. Just checking.

The tests are running ok in local machine btw 😭.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants